Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/FilmStripView.js

Issue 2608043002: DevTools: extract modules (with extensions) (Closed)
Patch Set: fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/FilmStripView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js b/third_party/WebKit/Source/devtools/front_end/components/FilmStripView.js
similarity index 94%
rename from third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js
rename to third_party/WebKit/Source/devtools/front_end/components/FilmStripView.js
index a4dd3957e5a8f469e3fb1e9d49d9a24e70279679..c9b87712faa4e4d986f8e4f00f3cb0fd46e9bfdd 100644
--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/FilmStripView.js
@@ -7,7 +7,7 @@
Components.FilmStripView = class extends UI.HBox {
constructor() {
super(true);
- this.registerRequiredCSS('components_lazy/filmStripView.css');
+ this.registerRequiredCSS('components/filmStripView.css');
this.contentElement.classList.add('film-strip-view');
this._statusLabel = this.contentElement.createChild('div', 'label');
this.reset();
@@ -33,7 +33,7 @@ Components.FilmStripView = class extends UI.HBox {
}
/**
- * @param {!Components.FilmStripModel} filmStripModel
+ * @param {!SDK.FilmStripModel} filmStripModel
* @param {number} zeroTime
* @param {number} spanTime
*/
@@ -50,7 +50,7 @@ Components.FilmStripView = class extends UI.HBox {
}
/**
- * @param {!Components.FilmStripModel.Frame} frame
+ * @param {!SDK.FilmStripModel.Frame} frame
* @return {!Promise<!Element>}
*/
createFrameElement(frame) {
@@ -80,12 +80,12 @@ Components.FilmStripView = class extends UI.HBox {
/**
* @param {number} time
- * @return {!Components.FilmStripModel.Frame}
+ * @return {!SDK.FilmStripModel.Frame}
*/
frameByTime(time) {
/**
* @param {number} time
- * @param {!Components.FilmStripModel.Frame} frame
+ * @param {!SDK.FilmStripModel.Frame} frame
* @return {number}
*/
function comparator(time, frame) {
@@ -169,7 +169,7 @@ Components.FilmStripView = class extends UI.HBox {
}
/**
- * @param {!Components.FilmStripModel.Frame} filmStripFrame
+ * @param {!SDK.FilmStripModel.Frame} filmStripFrame
*/
_onDoubleClick(filmStripFrame) {
new Components.FilmStripView.Dialog(filmStripFrame, this._zeroTime);
@@ -207,12 +207,12 @@ Components.FilmStripView.Modes = {
*/
Components.FilmStripView.Dialog = class extends UI.VBox {
/**
- * @param {!Components.FilmStripModel.Frame} filmStripFrame
+ * @param {!SDK.FilmStripModel.Frame} filmStripFrame
* @param {number=} zeroTime
*/
constructor(filmStripFrame, zeroTime) {
super(true);
- this.registerRequiredCSS('components_lazy/filmStripDialog.css');
+ this.registerRequiredCSS('components/filmStripDialog.css');
this.contentElement.classList.add('filmstrip-dialog');
this.contentElement.tabIndex = 0;

Powered by Google App Engine
This is Rietveld 408576698