Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/module.json

Issue 2608043002: DevTools: extract modules (with extensions) (Closed)
Patch Set: fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/components/module.json b/third_party/WebKit/Source/devtools/front_end/components/module.json
index dbbf8007e2f4e0c6a95e0eb177d03c009464c43d..ad1aeac402f71e2bbe4916d6d4039947a665d4c3 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/components/module.json
@@ -1,95 +1,81 @@
{
- "extensions": [
- {
- "type": "setting",
- "category": "Console",
- "title": "Enable custom formatters",
- "settingName": "customFormatters",
- "settingType": "boolean",
- "defaultValue": false
- },
- {
- "type": "@Components.DOMPresentationUtils.MarkerDecorator",
- "factoryName": "Components.DOMPresentationUtils.GenericDecorator",
- "marker": "breakpoint-marker",
- "title": "DOM Breakpoint",
- "color": "rgb(105, 140, 254)"
- },
- {
- "type": "setting",
- "settingName": "customNetworkConditions",
- "settingType": "array",
- "defaultValue": []
- },
- {
- "type": "@UI.ActionDelegate",
- "actionId": "components.network-offline",
- "category": "Network",
- "title": "Go offline",
- "className": "Components.NetworkConditionsActionDelegate",
- "tags": "device"
- },
- {
- "type": "@UI.ActionDelegate",
- "actionId": "components.network-online",
- "category": "Network",
- "title": "Go online",
- "className": "Components.NetworkConditionsActionDelegate",
- "tags": "device"
- },
- {
- "type": "view",
- "location": "settings-view",
- "id": "network-conditions",
- "title": "Throttling",
- "order": "35",
- "className": "Components.NetworkConditionsSettingsTab",
- "settings": [
- "customNetworkConditions"
- ]
- },
- {
- "type": "@UI.ActionDelegate",
- "category": "Mobile",
- "actionId": "components.request-app-banner",
- "className": "Components.RequestAppBannerActionDelegate",
- "title": "Add to homescreen"
- }
- ],
- "dependencies": [
- "bindings",
- "platform",
- "ui"
- ],
- "scripts": [
- "BreakpointsSidebarPaneBase.js",
- "CustomPreviewSection.js",
- "DataSaverInfobar.js",
- "DOMBreakpointsSidebarPane.js",
- "DOMPresentationUtils.js",
- "DockController.js",
- "ExecutionContextSelector.js",
- "JavaScriptAutocomplete.js",
- "Linkifier.js",
- "NetworkConditionsSelector.js",
- "ObjectPopoverHelper.js",
- "ObjectPropertiesSection.js",
- "RemoteObjectPreviewFormatter.js",
- "RequestAppBannerActionDelegate.js",
- "ShortcutsScreen.js",
- "Spectrum.js",
- "EventListenersUtils.js",
- "EventListenersView.js",
- "Reload.js"
- ],
- "resources": [
- "breakpointsList.css",
- "customPreviewSection.css",
- "eventListenersView.css",
- "domUtils.css",
- "networkConditionsSettingsTab.css",
- "objectPropertiesSection.css",
- "objectValue.css",
- "spectrum.css"
- ]
-}
+ "extensions": [
pfeldman 2017/01/05 20:27:53 single quote these?
chenwilliam 2017/01/05 22:40:25 JSON spec requires double quotes :(
pfeldman 2017/01/06 00:07:09 Ah! Maybe leave 4 spaces then? :) I still can't se
alancutter (OOO until 2018) 2017/01/06 00:26:43 The side-by-side diff accounts for the change in i
+ {
+ "type": "setting",
+ "category": "Console",
+ "title": "Enable custom formatters",
+ "settingName": "customFormatters",
+ "settingType": "boolean",
+ "defaultValue": false
+ },
+ {
+ "type": "@Components.DOMPresentationUtils.MarkerDecorator",
+ "factoryName": "Components.DOMPresentationUtils.GenericDecorator",
+ "marker": "breakpoint-marker",
+ "title": "DOM Breakpoint",
+ "color": "rgb(105, 140, 254)"
+ },
+ {
+ "type": "setting",
+ "settingName": "customNetworkConditions",
+ "settingType": "array",
+ "defaultValue": []
+ },
+ {
+ "type": "@UI.ActionDelegate",
+ "actionId": "components.network-offline",
+ "category": "Network",
+ "title": "Go offline",
+ "className": "Components.NetworkConditionsActionDelegate",
+ "tags": "device"
+ },
+ {
+ "type": "@UI.ActionDelegate",
+ "actionId": "components.network-online",
+ "category": "Network",
+ "title": "Go online",
+ "className": "Components.NetworkConditionsActionDelegate",
+ "tags": "device"
+ },
+ {
+ "type": "view",
+ "location": "settings-view",
+ "id": "network-conditions",
+ "title": "Throttling",
+ "order": "35",
+ "className": "Components.NetworkConditionsSettingsTab",
+ "settings": [
+ "customNetworkConditions"
+ ]
+ }
+ ],
+ "dependencies": [
+ "bindings",
+ "platform",
+ "ui"
+ ],
+ "scripts": [
+ "BreakpointsSidebarPaneBase.js",
+ "CustomPreviewSection.js",
+ "DOMBreakpointsSidebarPane.js",
+ "DOMPresentationUtils.js",
+ "DockController.js",
+ "JavaScriptAutocomplete.js",
+ "Linkifier.js",
+ "NetworkConditionsSelector.js",
+ "ObjectPopoverHelper.js",
+ "ObjectPropertiesSection.js",
+ "RemoteObjectPreviewFormatter.js",
+ "FilmStripView.js"
+ ],
+ "resources": [
+ "breakpointsList.css",
+ "customPreviewSection.css",
+ "domUtils.css",
+ "networkConditionsSettingsTab.css",
+ "objectPropertiesSection.css",
+ "objectValue.css",
+ "filmStripView.css",
+ "filmStripDialog.css"
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698