Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: third_party/WebKit/Source/devtools/front_end/js_ui/EventListenersUtils.js

Issue 2608043002: DevTools: extract modules (with extensions) (Closed)
Patch Set: fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/js_ui/EventListenersUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js b/third_party/WebKit/Source/devtools/front_end/js_ui/EventListenersUtils.js
similarity index 94%
rename from third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js
rename to third_party/WebKit/Source/devtools/front_end/js_ui/EventListenersUtils.js
index 5d13d66d54685b7df942580604a5bd78bf31a3fc..f93420105619135318868ca67644ed2f5e6df1f5 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/js_ui/EventListenersUtils.js
@@ -2,23 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/** @typedef {{eventListeners:!Array<!SDK.EventListener>, internalHandlers:?SDK.RemoteArray}} */
-Components.FrameworkEventListenersObject;
+JS_UI.FrameworkEventListenersObject;
/** @typedef {{type: string, useCapture: boolean, passive: boolean, once: boolean, handler: function()}} */
-Components.EventListenerObjectInInspectedPage;
+JS_UI.EventListenerObjectInInspectedPage;
/**
* @param {!SDK.RemoteObject} object
- * @return {!Promise<!Components.FrameworkEventListenersObject>}
+ * @return {!Promise<!JS_UI.FrameworkEventListenersObject>}
*/
-SDK.EventListener.frameworkEventListeners = function(object) {
+JS_UI.frameworkEventListeners = function(object) {
if (!object.target().hasDOMCapability()) {
// TODO(kozyatinskiy): figure out how this should work for |window|.
return Promise.resolve(
- /** @type {!Components.FrameworkEventListenersObject} */ ({eventListeners: [], internalHandlers: null}));
+ /** @type {!JS_UI.FrameworkEventListenersObject} */ ({eventListeners: [], internalHandlers: null}));
}
- var listenersResult = /** @type {!Components.FrameworkEventListenersObject} */ ({eventListeners: []});
+ var listenersResult = /** @type {!JS_UI.FrameworkEventListenersObject} */ ({eventListeners: []});
return object.callFunctionPromise(frameworkEventListeners, undefined)
.then(assertCallFunctionResult)
.then(getOwnProperties)
@@ -88,7 +88,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
/**
* @suppressReceiverCheck
- * @this {Components.EventListenerObjectInInspectedPage}
+ * @this {JS_UI.EventListenerObjectInInspectedPage}
* @return {!{type:string, useCapture:boolean, passive:boolean, once:boolean}}
*/
function truncatePageEventListener() {
@@ -114,7 +114,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
/**
* @suppressReceiverCheck
* @return {function()}
- * @this {Components.EventListenerObjectInInspectedPage}
+ * @this {JS_UI.EventListenerObjectInInspectedPage}
*/
function handlerFunction() {
return this.handler;
@@ -153,7 +153,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
/**
* @suppressReceiverCheck
* @return {function()}
- * @this {Components.EventListenerObjectInInspectedPage}
+ * @this {JS_UI.EventListenerObjectInInspectedPage}
*/
function getRemoveFunction() {
return this.remove;
@@ -223,7 +223,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
}
/**
- * @return {!Components.FrameworkEventListenersObject}
+ * @return {!JS_UI.FrameworkEventListenersObject}
*/
function returnResult() {
return listenersResult;
@@ -282,7 +282,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
*/
/**
* @suppressReceiverCheck
- * @return {!{eventListeners:!Array<!Components.EventListenerObjectInInspectedPage>, internalHandlers:?Array<function()>}}
+ * @return {!{eventListeners:!Array<!JS_UI.EventListenerObjectInInspectedPage>, internalHandlers:?Array<function()>}}
* @this {Object}
*/
function frameworkEventListeners() {
@@ -341,7 +341,7 @@ SDK.EventListener.frameworkEventListeners = function(object) {
/**
* @param {*} eventListener
- * @return {?Components.EventListenerObjectInInspectedPage}
+ * @return {?JS_UI.EventListenerObjectInInspectedPage}
*/
function checkEventListener(eventListener) {
try {

Powered by Google App Engine
This is Rietveld 408576698