Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2608023002: Remove unused function Compositor::setDeviceScaleFactor. (Closed)

Created:
3 years, 11 months ago by Shouqun1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused function Compositor::setDeviceScaleFactor. BUG= Committed: https://crrev.com/9cbab38d87210cb6a8fa69189bc314f756248032 Cr-Commit-Position: refs/heads/master@{#441312}

Patch Set 1 #

Patch Set 2 : refine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 3 chunks +1 line, -8 lines 0 comments Download
M content/public/browser/android/compositor.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Shouqun1
ptal
3 years, 11 months ago (2016-12-30 01:27:05 UTC) #2
aelias_OOO_until_Jul13
lgtm
3 years, 11 months ago (2017-01-03 21:15:07 UTC) #3
aelias_OOO_until_Jul13
Please update the patch to also delete unnecessary field "device_scale_factor_".
3 years, 11 months ago (2017-01-03 21:17:14 UTC) #4
Shouqun1
On 2017/01/03 21:17:14, aelias wrote: > Please update the patch to also delete unnecessary field ...
3 years, 11 months ago (2017-01-04 01:47:41 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 11 months ago (2017-01-04 03:01:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608023002/20001
3 years, 11 months ago (2017-01-04 03:01:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 03:41:45 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 03:43:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cbab38d87210cb6a8fa69189bc314f756248032
Cr-Commit-Position: refs/heads/master@{#441312}

Powered by Google App Engine
This is Rietveld 408576698