Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2608003002: DevTools: Remove unused code for details in SuggestBox (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove unused code for details in SuggestBox BUG=none Committed: https://crrev.com/7a9a358edbce6f1cb4b5843980a1bf26200da115 Cr-Commit-Position: refs/heads/master@{#441262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -60 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 4 chunks +1 line, -47 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
einbinder
ptal
3 years, 11 months ago (2016-12-30 00:31:15 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2016-12-30 00:38:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608003002/1
3 years, 11 months ago (2017-01-03 20:29:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/361837)
3 years, 11 months ago (2017-01-03 22:57:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608003002/1
3 years, 11 months ago (2017-01-03 23:00:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 00:23:27 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 00:27:24 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a9a358edbce6f1cb4b5843980a1bf26200da115
Cr-Commit-Position: refs/heads/master@{#441262}

Powered by Google App Engine
This is Rietveld 408576698