Move some sniffer arrays to read-only data segment

Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
Committed: https://crrev.com/40b53de7f19c627cca389d0904916ba81af58924
Cr-Commit-Position: refs/heads/master@{#441007}

[brucedawson, 2016-12-29 22:39:12]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 22:39:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-29 22:47:57]

Description was changed from

==========
Move net::kExtraMagicNumbers array to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
==========

to

==========
Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
==========

[brucedawson, 2016-12-29 22:54:21]

brucedawson@chromium.org changed reviewers:
+ asanka@chromium.org

[brucedawson, 2016-12-29 22:54:22]

Another place where *removing* const lets VC++ move data to the read-only data
segment, for a small win.

[asanka, 2016-12-29 23:03:38]

lgtm

[brucedawson, 2016-12-29 23:38:43]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2016-12-29 23:38:49]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-12-29 23:38:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 23:53:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483054729131830, "parent_rev":
"2063dcddc6c6c41a4f5f71b9525bda36146bdab2", "commit_rev":
"9ff17f6409abfd82e2cf2e654eadf1c03f70466a"}

[commit-bot: I haz the power, 2016-12-29 23:54:12]

Description was changed from

==========
Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
==========

to

==========
Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Review-Url: https://codereview.chromium.org/2607993002
==========

[commit-bot: I haz the power, 2016-12-29 23:54:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:53:51]

Description was changed from

==========
Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Review-Url: https://codereview.chromium.org/2607993002
==========

to

==========
Move some sniffer arrays to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Committed: https://crrev.com/40b53de7f19c627cca389d0904916ba81af58924
Cr-Commit-Position: refs/heads/master@{#441007}
==========

[commit-bot: I haz the power, 2017-01-02 15:53:52]

Patchset 1 (id:??) landed as
https://crrev.com/40b53de7f19c627cca389d0904916ba81af58924
Cr-Commit-Position: refs/heads/master@{#441007}