Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2607983002:
avoid GCC content::CacheStorage::kSizeUnknown redeclaration error (Closed)
|
Created:
3 years, 11 months ago by Mostyn Bramley-Moore Modified:
3 years, 11 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionavoid GCC content::CacheStorage::kSizeUnknown redeclaration error
Fixes:
../../content/browser/cache_storage/cache_storage.cc:62:29: error: redeclaration 'content::CacheStorage::kSizeUnknown' differs in 'constexpr'
BUG=617963
Review-Url: https://codereview.chromium.org/2607983002
Cr-Commit-Position: refs/heads/master@{#442242}
Committed: https://chromium.googlesource.com/chromium/src/+/1c7f20d3d858eb3381c003970a2d9179c2437a47
Patch Set 1 #Patch Set 2 : git cl upload fail #Patch Set 3 : attempt #2 #Patch Set 4 : formatting #
Total comments: 2
Patch Set 5 : const -> constexpr #Messages
Total messages: 26 (19 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== avoid GCC content::CacheStorage::kSizeUnknown redeclaration error BUG= ========== to ========== avoid GCC content::CacheStorage::kSizeUnknown redeclaration error Fixes: ../../content/browser/cache_storage/cache_storage.cc:62:29: error: redeclaration 'content::CacheStorage::kSizeUnknown' differs in 'constexpr' BUG=617963 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mostynb@opera.com changed reviewers: + cmumford@chromium.org, jkarlin@chromium.org
@jkarlin, cmumford: please take a look at this followup to https://codereview.chromium.org/2416713002
https://codereview.chromium.org/2607983002/diff/60001/content/browser/cache_s... File content/browser/cache_storage/cache_storage.cc (left): https://codereview.chromium.org/2607983002/diff/60001/content/browser/cache_s... content/browser/cache_storage/cache_storage.cc:62: const int64_t CacheStorage::kSizeUnknown; Can this gcc issue be fixed by changing this const to constexpr?
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2607983002/diff/60001/content/browser/cache_s... File content/browser/cache_storage/cache_storage.cc (left): https://codereview.chromium.org/2607983002/diff/60001/content/browser/cache_s... content/browser/cache_storage/cache_storage.cc:62: const int64_t CacheStorage::kSizeUnknown; On 2017/01/03 13:06:25, jkarlin wrote: > Can this gcc issue be fixed by changing this const to constexpr? Seems to work. CQ dry run underway to confirm.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
@jkarlin: *ping*
lgtm
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483964735187900,
"parent_rev": "37a573c4fa9f8b95119c656abbed6f72d808c832", "commit_rev":
"1c7f20d3d858eb3381c003970a2d9179c2437a47"}
Message was sent while issue was closed.
Description was changed from ========== avoid GCC content::CacheStorage::kSizeUnknown redeclaration error Fixes: ../../content/browser/cache_storage/cache_storage.cc:62:29: error: redeclaration 'content::CacheStorage::kSizeUnknown' differs in 'constexpr' BUG=617963 ========== to ========== avoid GCC content::CacheStorage::kSizeUnknown redeclaration error Fixes: ../../content/browser/cache_storage/cache_storage.cc:62:29: error: redeclaration 'content::CacheStorage::kSizeUnknown' differs in 'constexpr' BUG=617963 Review-Url: https://codereview.chromium.org/2607983002 Cr-Commit-Position: refs/heads/master@{#442242} Committed: https://chromium.googlesource.com/chromium/src/+/1c7f20d3d858eb3381c003970a2d... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/1c7f20d3d858eb3381c003970a2d... |
