Remove Blimp from waterfall configurations and buildbot recipes.

Remove Blimp from waterfall configurations and buildbot recipes.

R=amineer@chromium.org
BUG=677556
Review-Url: https://codereview.chromium.org/2607973002
Cr-Commit-Position: refs/heads/master@{#441714}
Committed: https://chromium.googlesource.com/chromium/src/+/5b0a370f79fa029a4b1a87f09186bfabbd108406

[Kevin M, 2016-12-29 22:03:03]

The CQ bit was checked by kmarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 22:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kevin M, 2016-12-29 22:12:05]

Description was changed from

==========
Remove Blimp targets and configurations from buildbots.

R=amineer@chromium.org
BUG=677556
==========

to

==========
Remove Blimp targets and configurations from buildbots.

R=amineer@chromium.org
BUG=677556
==========

[Kevin M, 2016-12-29 22:12:28]

Description was changed from

==========
Remove Blimp targets and configurations from buildbots.

R=amineer@chromium.org
BUG=677556
==========

to

==========
Remove Blimp from waterfall configurations and buildbot recipes.

R=amineer@chromium.org
BUG=677556
==========

[Kevin M, 2016-12-29 22:20:18]

kmarshall@chromium.org changed reviewers:
+ dpranke@google.com

[commit-bot: I haz the power, 2016-12-29 23:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 23:05:20]

Dry run: This issue passed the CQ dry run.

[amineer, 2017-01-04 00:41:50]

On 2017/01/03 17:58:48, Kevin M wrote:

I have no objection to this, but I've never touched these files myself, so I
can't really tell if you're doing is properly or if there will be other
downstream ramifications (e.g. actual builders that need to be restarted or
whatever).  Perhaps Dirk can speak to these more definitively?

[Dirk Pranke, 2017-01-04 02:54:19]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-01-04 02:54:20]

This mostly looks okay, but I think chromium.fyi.json needs to be tweaked as per
the comment below.

https://codereview.chromium.org/2607973002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2607973002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.fyi.json:1517: "browser side navigation linux": {
You changed the capitalization of a bunch of builders in this file. I'm guessing
that was unintentional, but I think it's also confusing the diff logic, making
this hard to review.

[chromium-reviews, 2017-01-04 19:04:20]

I'll fix that, but FYI, the recapitalization was done by the automatic
fixup tool recommended by the linter.

(Can't repro for now; power is out in KIR)

On Tue, Jan 3, 2017 at 6:54 PM, <dpranke@chromium.org> wrote:

> This mostly looks okay, but I think chromium.fyi.json needs to be tweaked
> as per
> the comment below.
>
>
> https://codereview.chromium.org/2607973002/diff/20001/
> testing/buildbot/chromium.fyi.json
> File testing/buildbot/chromium.fyi.json (right):
>
> https://codereview.chromium.org/2607973002/diff/20001/
> testing/buildbot/chromium.fyi.json#newcode1517
> testing/buildbot/chromium.fyi.json:1517: "browser side navigation
> linux": {
> You changed the capitalization of a bunch of builders in this file. I'm
> guessing that was unintentional, but I think it's also confusing the
> diff logic, making this hard to review.
>
> https://codereview.chromium.org/2607973002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2017-01-04 19:08:00]

On 2017/01/04 19:04:20, chromium-reviews wrote:
> I'll fix that, but FYI, the recapitalization was done by the automatic
> fixup tool recommended by the linter.

The fixup tool modified keys in a JSON file? That seems like a really bad thing
...

[Kevin M, 2017-01-05 00:24:06]

Can't repro. Might have been a typo in Vim on my part.

[Kevin M, 2017-01-05 00:29:06]

PTAL

[Dirk Pranke, 2017-01-05 02:08:08]

That diff is much better :).

lgtm.

[Kevin M, 2017-01-05 17:29:55]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2017-01-05 17:30:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:49:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483637395379820,
"parent_rev": "a918c03eaaf3670312aae46b812ffa16012ad338", "commit_rev":
"5b0a370f79fa029a4b1a87f09186bfabbd108406"}

[commit-bot: I haz the power, 2017-01-05 18:49:33]

Description was changed from

==========
Remove Blimp from waterfall configurations and buildbot recipes.

R=amineer@chromium.org
BUG=677556
==========

to

==========
Remove Blimp from waterfall configurations and buildbot recipes.

R=amineer@chromium.org
BUG=677556

Review-Url: https://codereview.chromium.org/2607973002
Cr-Commit-Position: refs/heads/master@{#441714}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b0a370f79fa029a4b1a87f09186...
==========

[commit-bot: I haz the power, 2017-01-05 18:49:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5b0a370f79fa029a4b1a87f09186...

[sky, 2017-01-05 19:12:58]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2615633009/ by sky@chromium.org.

The reason for reverting is: Reverting in hopes of fixing
https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%2....

[Dirk Pranke, 2017-01-05 19:37:23]

On 2017/01/05 19:12:58, sky wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2615633009/ by mailto:sky@chromium.org.
> 
> The reason for reverting is: Reverting in hopes of fixing
>
https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%2....

Urk. I thought we had already removed the blimp builders :(. We need to do that
first.