MacViews: Handle Space and Return keys correctly for Buttons.

ui/views/controls/button/custom_button.h

Index: ui/views/controls/button/custom_button.h
diff --git a/ui/views/controls/button/custom_button.h b/ui/views/controls/button/custom_button.h
index 03a8b161b898a7ec7d2e44beac06839861adeb6b..29cb6448194f1d485780023d703b17b6e6c0be16 100644
--- a/ui/views/controls/button/custom_button.h
+++ b/ui/views/controls/button/custom_button.h
@@ -29,6 +29,14 @@ class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
     NOTIFY_ON_RELEASE,
   };
 
+  // An enum describing the action to perform on a key press.

[tapted, 2017/01/04 04:54:31]

since this deals with press and release, the comment doesn't sound right. Maybe

// An enum describing how a given key code should affect the button state.

[karandeepb, 2017/01/04 06:14:45]

Changed to "An enum describing the events on which a button should be clicked
for a given key event." to make it consistent with the comment for NotifyAction.

[tapted, 2017/01/05 00:34:41]

sg

+  enum ButtonAction {
+    ACTION_PRESS,  // The button is pressed on OnKeyPressed and clicked on

[tapted, 2017/01/04 04:54:31]

Perhaps CLICK_ON_PRESS / CLICK_ON_RELEASE / CLICK_NONE?

(and I guess `ClickAction` would make it more consistent with the above too)

[karandeepb, 2017/01/04 06:14:45]

Yeah this seems better.

+                   // OnKeyReleased.
+    ACTION_CLICK,  // The button is clicked on OnKeyPressed.
+    ACTION_NONE,   // No action is performed.
+  };
+
   // The menu button's class name.
   static const char kViewClassName[];