MacViews: Handle Space and Return keys correctly for Buttons.

ui/views/controls/button/custom_button.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_CUSTOM_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_CUSTOM_BUTTON_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 11 matching lines @@
 // part of the focus chain, unless in accessibility mode. Call
 // SetFocusForPlatform() to make it part of the focus chain.
 class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
  public:
   // An enum describing the events on which a button should notify its listener.
   enum NotifyAction {
     NOTIFY_ON_PRESS,
     NOTIFY_ON_RELEASE,
   };
 
+  // An enum describing the action to perform on a key press.

[tapted, 2017/01/04 04:54:31]

since this deals with press and release, the comment doesn't sound right. Maybe

// An enum describing how a given key code should affect the button state.

[karandeepb, 2017/01/04 06:14:45]

Changed to "An enum describing the events on which a button should be clicked
for a given key event." to make it consistent with the comment for NotifyAction.

[tapted, 2017/01/05 00:34:41]

sg

+  enum ButtonAction {
+    ACTION_PRESS,  // The button is pressed on OnKeyPressed and clicked on

[tapted, 2017/01/04 04:54:31]

Perhaps CLICK_ON_PRESS / CLICK_ON_RELEASE / CLICK_NONE?

(and I guess `ClickAction` would make it more consistent with the above too)

[karandeepb, 2017/01/04 06:14:45]

Yeah this seems better.

+                   // OnKeyReleased.
+    ACTION_CLICK,  // The button is clicked on OnKeyPressed.
+    ACTION_NONE,   // No action is performed.
+  };
+
   // The menu button's class name.
   static const char kViewClassName[];
 
   static const CustomButton* AsCustomButton(const View* view);
   static CustomButton* AsCustomButton(View* view);
 
   ~CustomButton() override;
 
   // Get/sets the current display state of the button.
   ButtonState state() const { return state_; }
@@ skipping 151 matching lines @@
 
   // The color of the ripple and hover.
   SkColor ink_drop_base_color_;
 
   DISALLOW_COPY_AND_ASSIGN(CustomButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_CUSTOM_BUTTON_H_