Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: ui/views/style/platform_style_mac.mm

Issue 2607923002: MacViews: Handle Space and Return keys correctly for Buttons. (Closed)
Patch Set: Address review. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/style/platform_style_mac.mm
diff --git a/ui/views/style/platform_style_mac.mm b/ui/views/style/platform_style_mac.mm
index 4e07484e09028f50267ef9ee6733c3df515457f9..d747cefa394447c74f24a1eb66395d4de7a7a615 100644
--- a/ui/views/style/platform_style_mac.mm
+++ b/ui/views/style/platform_style_mac.mm
@@ -37,6 +37,13 @@
const CustomButton::NotifyAction PlatformStyle::kMenuNotifyActivationAction =
CustomButton::NOTIFY_ON_PRESS;
+const CustomButton::ClickAction PlatformStyle::kClickActionOnSpace =
+ CustomButton::CLICK_ON_PRESS;
+
+// On Mac, the Return Key is used to perform the default action even when a
+// control is focused.
tapted 2017/01/05 00:34:41 With extended comment in platform_style.h, this co
karandeepb 2017/01/05 10:50:09 I'll let this remain since this explains that Retu
+const bool PlatformStyle::kReturnClicksFocusedControl = false;
+
// static
gfx::ImageSkia PlatformStyle::CreateComboboxArrow(bool is_enabled,
Combobox::Style style) {

Powered by Google App Engine
This is Rietveld 408576698