Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: ui/views/style/platform_style.h

Issue 2607923002: MacViews: Handle Space and Return keys correctly for Buttons. (Closed)
Patch Set: Address review. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/style/platform_style.h
diff --git a/ui/views/style/platform_style.h b/ui/views/style/platform_style.h
index e71720fbce3b714c30ebabab18757260a0eec5ac..6b5817cf86dbfd346a9bcb705ed3c9dd9b086582 100644
--- a/ui/views/style/platform_style.h
+++ b/ui/views/style/platform_style.h
@@ -46,6 +46,12 @@ class VIEWS_EXPORT PlatformStyle {
// The menu button's action to show the menu.
static const CustomButton::NotifyAction kMenuNotifyActivationAction;
+ // Click action to perform on a button when the Space key is pressed.
tapted 2017/01/05 00:34:41 This comment doesn't read quite right, since "pres
karandeepb 2017/01/05 10:50:09 Done.
+ static const CustomButton::ClickAction kClickActionOnSpace;
+
+ // Whether Return key clicks the focused control.
tapted 2017/01/05 00:34:41 It might be good to be explicit here too. E.g. "
karandeepb 2017/01/05 10:50:09 Done.
+ static const bool kReturnClicksFocusedControl;
+
// Whether TreeViews get a focus ring on the entire TreeView when focused.
static const bool kTreeViewHasFocusRing;

Powered by Google App Engine
This is Rietveld 408576698