Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2607883002: MD Settings: users: Register UserImageSource in handler (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
tommycli, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: users: Register UserImageSource in handler BUG=669003 Committed: https://crrev.com/d10629b867e1399c2339f078ac3d16f0b402248d Cr-Commit-Position: refs/heads/master@{#441182}

Patch Set 1 #

Patch Set 2 : Make cros only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
stevenjb
3 years, 11 months ago (2016-12-29 00:26:17 UTC) #2
stevenjb
michaelpg@, it looks like you're back before Tommy, so ptal when you have a chance, ...
3 years, 11 months ago (2016-12-29 00:38:03 UTC) #4
michaelpg
lgtm
3 years, 11 months ago (2016-12-29 19:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607883002/1
3 years, 11 months ago (2016-12-29 20:56:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/215078)
3 years, 11 months ago (2016-12-29 21:11:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607883002/20001
3 years, 11 months ago (2017-01-03 18:53:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 19:34:26 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:39:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d10629b867e1399c2339f078ac3d16f0b402248d
Cr-Commit-Position: refs/heads/master@{#441182}

Powered by Google App Engine
This is Rietveld 408576698