Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2607853003: CSS Animations: Fix flaky composited-animations-simple.html (Closed)

Created:
3 years, 11 months ago by Eric Willigers
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Animations: Fix flaky composited-animations-simple.html We wait for the compositor before declaring the test complete. BUG=664857 Committed: https://crrev.com/50b12df39a684cea45639d2d758a9b6dbd6d16df Cr-Commit-Position: refs/heads/master@{#441256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eric Willigers
3 years, 11 months ago (2016-12-29 09:15:08 UTC) #4
alancutter (OOO until 2018)
lgtm. Bit weird to use the error element, I'd prefer something less arbitrary.
3 years, 11 months ago (2017-01-03 00:03:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607853003/1
3 years, 11 months ago (2017-01-03 22:49:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 00:00:40 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 00:03:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50b12df39a684cea45639d2d758a9b6dbd6d16df
Cr-Commit-Position: refs/heads/master@{#441256}

Powered by Google App Engine
This is Rietveld 408576698