[System health] Add google india search story

[System health] Add google india search story

BUG=669582
Committed: https://crrev.com/b6ab64ee4f8bd09be8b05d550db448e0b2b66d34
Cr-Commit-Position: refs/heads/master@{#441160}

[nednguyen, 2016-12-28 19:37:57]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 19:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-12-28 19:39:05]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org, rnephew@chromium.org

[commit-bot: I haz the power, 2016-12-28 20:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 20:32:17]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-12-29 17:48:25]

Patchset #2 (id:20001) has been deleted

[rnephew (Reviews Here), 2017-01-03 17:03:11]

lgtm with two questions.

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:297: _ Start at
https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2`
Any reason these are underscores? Just want to make sure we are setting a good
style precedent.

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:321:
action_runner.ExecuteJavaScript(
I assume this is entering text into the search text box. Should we do it the
same way as the english one in browse:search:google? Or does it not being
english characters make that impossible?

[nednguyen, 2017-01-03 17:19:24]

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:297: _ Start at
https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2`
On 2017/01/03 17:03:11, rnephew (Reviews Here) wrote:
> Any reason these are underscores? Just want to make sure we are setting a good
> style precedent. 

Oops, no reason at all. It's me being silly. :P

Done.

https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:321:
action_runner.ExecuteJavaScript(
On 2017/01/03 17:03:11, rnephew (Reviews Here) wrote:
> I assume this is entering text into the search text box. Should we do it the
> same way as the english one in browse:search:google? Or does it not being
> english characters make that impossible?

Correct. This text not being English makes it impossible. Possibly there are
someway how Indian text get put in but I don't know how.

Left a TODO here

[nednguyen, 2017-01-03 17:19:30]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-01-03 17:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from rnephew@chromium.org
Link to the patchset: https://codereview.chromium.org/2607793002/#ps40001
(title: "Address Randy's comment")

[commit-bot: I haz the power, 2017-01-03 17:19:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:17:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483463970918240,
"parent_rev": "77d227032e12c686f1950ac16157365738008df3", "commit_rev":
"700e3d14f1b1df939ef7838e93826ab2084a11ff"}

[commit-bot: I haz the power, 2017-01-03 18:17:48]

Description was changed from

==========
[System health] Add google india search story

BUG=669582
==========

to

==========
[System health] Add google india search story

BUG=669582

Review-Url: https://codereview.chromium.org/2607793002
==========

[commit-bot: I haz the power, 2017-01-03 18:17:49]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2017-01-03 18:21:20]

Description was changed from

==========
[System health] Add google india search story

BUG=669582

Review-Url: https://codereview.chromium.org/2607793002
==========

to

==========
[System health] Add google india search story

BUG=669582

Committed: https://crrev.com/b6ab64ee4f8bd09be8b05d550db448e0b2b66d34
Cr-Commit-Position: refs/heads/master@{#441160}
==========

[commit-bot: I haz the power, 2017-01-03 18:21:21]

Patchset 2 (id:??) landed as
https://crrev.com/b6ab64ee4f8bd09be8b05d550db448e0b2b66d34
Cr-Commit-Position: refs/heads/master@{#441160}