Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2607793002: [System health] Add google india search story (Closed)

Created:
3 years, 11 months ago by nednguyen
Modified:
3 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[System health] Add google india search story BUG=669582 Committed: https://crrev.com/b6ab64ee4f8bd09be8b05d550db448e0b2b66d34 Cr-Commit-Position: refs/heads/master@{#441160}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Randy's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M tools/perf/page_sets/data/system_health_desktop.json View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_039.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 3 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
nednguyen
3 years, 11 months ago (2016-12-28 19:39:05 UTC) #4
rnephew (Reviews Here)
lgtm with two questions. https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py File tools/perf/page_sets/system_health/browsing_stories.py (right): https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py#newcode297 tools/perf/page_sets/system_health/browsing_stories.py:297: _ Start at https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2` Any ...
3 years, 11 months ago (2017-01-03 17:03:11 UTC) #8
nednguyen
https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py File tools/perf/page_sets/system_health/browsing_stories.py (right): https://codereview.chromium.org/2607793002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py#newcode297 tools/perf/page_sets/system_health/browsing_stories.py:297: _ Start at https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2` On 2017/01/03 17:03:11, rnephew (Reviews ...
3 years, 11 months ago (2017-01-03 17:19:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607793002/40001
3 years, 11 months ago (2017-01-03 17:19:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
3 years, 11 months ago (2017-01-03 18:17:49 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 18:21:21 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6ab64ee4f8bd09be8b05d550db448e0b2b66d34
Cr-Commit-Position: refs/heads/master@{#441160}

Powered by Google App Engine
This is Rietveld 408576698