Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2607773003: [Extensions] Add metrics for extension initialization (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add metrics for extension initialization Add a histogram to analyze extension initialization time. BUG=677299 Review-Url: https://codereview.chromium.org/2607773003 Cr-Commit-Position: refs/heads/master@{#442760} Committed: https://chromium.googlesource.com/chromium/src/+/c9f9c596f4d35ec6d14ff78f8be7a08bfc989041

Patch Set 1 #

Patch Set 2 : suffixes #

Total comments: 2

Patch Set 3 : Mark's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M extensions/common/extension.cc View 1 4 chunks +25 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Devlin
Hey folks, mind taking a look?
3 years, 11 months ago (2016-12-28 20:46:01 UTC) #2
lazyboy
extension.cc lgtm.
3 years, 11 months ago (2017-01-05 00:17:02 UTC) #3
Mark P
lgtm with one comment --mark https://codereview.chromium.org/2607773003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2607773003/diff/20001/tools/metrics/histograms/histograms.xml#newcode114088 tools/metrics/histograms/histograms.xml:114088: + <suffix name="RendererProcess" label="Renderer ...
3 years, 11 months ago (2017-01-05 22:51:25 UTC) #4
Devlin
https://codereview.chromium.org/2607773003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2607773003/diff/20001/tools/metrics/histograms/histograms.xml#newcode114088 tools/metrics/histograms/histograms.xml:114088: + <suffix name="RendererProcess" label="Renderer Process (non-extension)"/> On 2017/01/05 22:51:24, ...
3 years, 11 months ago (2017-01-10 23:17:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607773003/40001
3 years, 11 months ago (2017-01-11 01:29:29 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:35:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c9f9c596f4d35ec6d14ff78f8be7...

Powered by Google App Engine
This is Rietveld 408576698