Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2607753002: SharedWorker: Make sure route_id is always valid in WebSharedWorkerProxy (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, kinuko+watch, jam, darin-cc_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SharedWorker: Make sure route_id is always valid in WebSharedWorkerProxy |route_id| passed to the ctor of WebSharedWorkerProxy is always valid because it's assigned by synchronous IPC ("ViewHostMsg_CreateWorker") in SharedWorkerRepository::createSharedWorkerConnector before creating the proxy. BUG=612308 Committed: https://crrev.com/d8b82c0b2a4db7b524f3272b64fea16e2594a6fb Cr-Commit-Position: refs/heads/master@{#441590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -23 lines) Patch
M content/renderer/websharedworker_proxy.h View 3 chunks +1 line, -5 lines 0 comments Download
M content/renderer/websharedworker_proxy.cc View 2 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
nhiroki
PTAL (Sorry for pushing a bunch of review requests in your queue :p)
3 years, 11 months ago (2016-12-28 10:08:36 UTC) #7
kinuko
lgtm
3 years, 11 months ago (2017-01-05 04:45:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607753002/1
3 years, 11 months ago (2017-01-05 04:46:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 05:41:02 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 05:44:18 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8b82c0b2a4db7b524f3272b64fea16e2594a6fb
Cr-Commit-Position: refs/heads/master@{#441590}

Powered by Google App Engine
This is Rietveld 408576698