Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2607743002: Remove existingWindowProxy() (Closed)

Created:
3 years, 12 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove existingWindowProxy() The only call site of existingWindowProxy() is V8Initializer::messageHandlerInMainThread(). However, as commented in the code, that code should not be needed because if the context is during initialization it should already have bailed out at the if(!scriptState->contextIsValid()) check at the very beginning of V8Initializer::messageHandlerInMainThread(). If the reasoning is correct, we can simply remove all code around existingWindowProxy(). BUG=677253 Committed: https://crrev.com/45830933ad06e7f8a213e97269522469b1602863 Cr-Commit-Position: refs/heads/master@{#440840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -32 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
haraken
PTAL
3 years, 12 months ago (2016-12-28 08:28:09 UTC) #2
Yuki
LGTM.
3 years, 12 months ago (2016-12-28 08:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607743002/1
3 years, 12 months ago (2016-12-28 08:46:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-28 10:08:44 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45830933ad06e7f8a213e97269522469b1602863
Cr-Commit-Position: refs/heads/master@{#440840}

Powered by Google App Engine
This is Rietveld 408576698