Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2607723002: Remove @RetryOnFailure in IME test (Closed)

Created:
3 years, 11 months ago by yabinh
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove @RetryOnFailure in IME test A lot of IME tests were flaky and marked with @RetryOnFailure. Now they are (almost) all deflaked, so we don't need @RetryOnFailure any more. BUG=628964, 603991 Committed: https://crrev.com/c3fe81c87f6e16071f9b3b3ca9d57d023b58cbb6 Cr-Commit-Position: refs/heads/master@{#440836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 47 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yabinh
On 2016/12/28 06:54:45, yabinh wrote: > The CQ bit was checked by mailto:yabinh@chromium.org to run ...
3 years, 11 months ago (2016-12-28 07:01:11 UTC) #3
yabinh
Check the flaky dash board: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=content_shell_test_apk&tests=imetest
3 years, 11 months ago (2016-12-28 07:02:31 UTC) #4
yabinh
PTAL, thanks
3 years, 11 months ago (2016-12-28 07:23:08 UTC) #8
Changwan Ryu
lgtm
3 years, 11 months ago (2016-12-28 07:38:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607723002/1
3 years, 11 months ago (2016-12-28 07:39:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 07:43:46 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3fe81c87f6e16071f9b3b3ca9d57d023b58cbb6
Cr-Commit-Position: refs/heads/master@{#440836}

Powered by Google App Engine
This is Rietveld 408576698