Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2607653002: MD History: clang-format Javascript files (again!) (Closed)

Created:
3 years, 12 months ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: clang-format Javascript files (again!) The clang-format Javascript style changed in crrev.com/440558 to prevent single-line functions. This CL updates the Javascript in MD History to follow this change. BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/df5e64aa56446d6f0de0f7956358b49c066422ec Cr-Commit-Position: refs/heads/master@{#440833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -38 lines) Patch
M chrome/browser/resources/md_history/app.js View 7 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_history/browser_service.js View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/grouped_list.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list_behavior.js View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.js View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 6 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tsergeant
Let it be known that I'm a huge fan of this change.
3 years, 12 months ago (2016-12-27 23:41:38 UTC) #5
Dan Beam
lgtm
3 years, 12 months ago (2016-12-28 05:30:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607653002/1
3 years, 12 months ago (2016-12-28 06:09:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-28 06:14:23 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df5e64aa56446d6f0de0f7956358b49c066422ec
Cr-Commit-Position: refs/heads/master@{#440833}

Powered by Google App Engine
This is Rietveld 408576698