Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

BUG=615156
NOTRY=true

Committed: https://crrev.com/6745b5983e3a13ebfc63c500892e2cd7f9810263
Cr-Commit-Position: refs/heads/master@{#440805}

[Łukasz Anforowicz, 2016-12-27 23:14:58]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org

[Łukasz Anforowicz, 2016-12-27 23:14:59]

Alex, can you PTAL?  This should make the test expectations match the actual
result on the FYI bots (which see text diff rather than timeout).  Hopefully the
test expectation can be removed once Ken's CL you pointed out lands
(https://codereview.chromium.org/2431473003).

[alexmos, 2016-12-27 23:27:27]

LGTM

[Łukasz Anforowicz, 2016-12-27 23:30:13]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 23:34:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482881413361510, "parent_rev":
"56737f8020fd58457348b3b42e2c03893c9ef0f0", "commit_rev":
"99f35392e5542089b291b39a79f718a57f84b10e"}

[commit-bot: I haz the power, 2016-12-27 23:34:54]

Description was changed from

==========
Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

BUG=615156
NOTRY=true
==========

to

==========
Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

BUG=615156
NOTRY=true

Review-Url: https://codereview.chromium.org/2607643002
==========

[commit-bot: I haz the power, 2016-12-27 23:34:55]

Committed patchset #1 (id:1)

[szager1, 2016-12-27 23:42:56]

szager@chromium.org changed reviewers:
+ szager@chromium.org

[szager1, 2016-12-27 23:42:57]

What is this?  Why is the test failing?  It should not be failing.

[Łukasz Anforowicz, 2016-12-27 23:46:38]

On 2016/12/27 23:42:57, szager1 wrote:
> What is this?  Why is the test failing?  It should not be failing.

It is a known issue that intersection observed doesn't work in presence of
OOPIFs - this is tracked in https://crbug.com/615156 and kenrb@ should be
landing a fix for this soon.  In the meantime, this CL tries to keep the Site
Isolation FYI bots green, so we won't miss any *new* / unknown issues or test
failures.  Please note that this CL tweaks test expectations *only* for cases
when layout tests are run with --site-per-process flag (i.e. this CL tweaks
LayoutTests/FlagExpectations/site-per-process rather then
LayoutTests/TestExpectations).

[szager1, 2016-12-27 23:48:46]

On 2016/12/27 23:46:38, Łukasz Anforowicz wrote:
> On 2016/12/27 23:42:57, szager1 wrote:
> > What is this?  Why is the test failing?  It should not be failing.
> 
> It is a known issue that intersection observed doesn't work in presence of
> OOPIFs - this is tracked in https://crbug.com/615156 and kenrb@ should be
> landing a fix for this soon.  In the meantime, this CL tries to keep the Site
> Isolation FYI bots green, so we won't miss any *new* / unknown issues or test
> failures.  Please note that this CL tweaks test expectations *only* for cases
> when layout tests are run with --site-per-process flag (i.e. this CL tweaks
> LayoutTests/FlagExpectations/site-per-process rather then
> LayoutTests/TestExpectations).

OK, I thought kenrb's CL had already landed.  For reference, this patch should
fix the test:

https://codereview.chromium.org/2431473003/

[commit-bot: I haz the power, 2017-01-02 15:47:48]

Description was changed from

==========
Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

BUG=615156
NOTRY=true

Review-Url: https://codereview.chromium.org/2607643002
==========

to

==========
Text-diff expectation for h/t/intersection-observer/iframe-cross-origin.html

BUG=615156
NOTRY=true

Committed: https://crrev.com/6745b5983e3a13ebfc63c500892e2cd7f9810263
Cr-Commit-Position: refs/heads/master@{#440805}
==========

[commit-bot: I haz the power, 2017-01-02 15:47:49]

Patchset 1 (id:??) landed as
https://crrev.com/6745b5983e3a13ebfc63c500892e2cd7f9810263
Cr-Commit-Position: refs/heads/master@{#440805}