Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2607623002: Introduce RevalidationStartForbiddenScope (Closed)

Created:
3 years, 12 months ago by hiroshige
Modified:
3 years, 11 months ago
Reviewers:
Nate Chapin, yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce RevalidationStartForbiddenScope This CL makes revalidation-related CHECK()s in RawResource::didAddClient() cleaner and enables us to identify how revalidation is actually started as the crash stack trace of Resource::setRevalidatingRequest(). BUG=640291, 648945 Committed: https://crrev.com/7b18efa1312b262c6277c66fd01ef114e75d6ae0 Cr-Commit-Position: refs/heads/master@{#440794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hiroshige
PTAL.
3 years, 12 months ago (2016-12-27 21:07:07 UTC) #6
Nate Chapin
lgtm
3 years, 12 months ago (2016-12-27 21:16:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607623002/1
3 years, 12 months ago (2016-12-27 21:51:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 22:09:22 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b18efa1312b262c6277c66fd01ef114e75d6ae0
Cr-Commit-Position: refs/heads/master@{#440794}

Powered by Google App Engine
This is Rietveld 408576698