Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: appengine/findit/crash/changelist_classifier.py

Issue 2607613002: Converting Region class to a namedtuple (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/libs/gitiles/blame.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/changelist_classifier.py
diff --git a/appengine/findit/crash/changelist_classifier.py b/appengine/findit/crash/changelist_classifier.py
index 3743ae6110eaf5fdc0636259b78614a911d503a1..2d84b021f296ebcafea7f8cbd01ddfafdcfde9e5 100644
--- a/appengine/findit/crash/changelist_classifier.py
+++ b/appengine/findit/crash/changelist_classifier.py
@@ -8,6 +8,7 @@ from collections import namedtuple
from common import chrome_dependency_fetcher
from crash import crash_util
+from crash.suspect import StackInfo
from crash.suspect import Suspect
from crash.suspect import SuspectMap
from crash.scorers.aggregated_scorer import AggregatedScorer
@@ -191,16 +192,11 @@ def GetChangeLogsForFilesGroupedByDeps(regression_deps_rolls, stack_deps,
if not dep_roll:
continue
- dep_roll = regression_deps_rolls[dep]
-
repository.repo_url = dep_roll.repo_url
changelogs = repository.GetChangeLogs(dep_roll.old_revision,
dep_roll.new_revision)
- if not changelogs:
- continue
-
- for changelog in changelogs:
+ for changelog in changelogs or []:
# When someone reverts, we need to skip both the CL doing
# the reverting as well as the CL that got reverted. If
# ``reverted_revision`` is true, then this CL reverts another one,
@@ -252,8 +248,8 @@ def GetStackInfosForFilesGroupedByDeps(stacktrace, stack_deps):
if frame.dep_path not in stack_deps:
continue
- dep_to_file_to_stack_infos[frame.dep_path][frame.file_path].append((
- frame, callstack.priority))
+ dep_to_file_to_stack_infos[frame.dep_path][frame.file_path].append(
+ StackInfo(frame, callstack.priority))
return dep_to_file_to_stack_infos
« no previous file with comments | « no previous file | appengine/findit/libs/gitiles/blame.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698