Converting Region class to a namedtuple

appengine/findit/crash/changelist_classifier.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 from collections import defaultdict
 from collections import namedtuple
 
 from common import chrome_dependency_fetcher
 from crash import crash_util
+from crash.suspect import StackInfo
 from crash.suspect import Suspect
 from crash.suspect import SuspectMap
 from crash.scorers.aggregated_scorer import AggregatedScorer
 from crash.scorers.min_distance import MinDistance
 from crash.scorers.top_frame_index import TopFrameIndex
 from crash.stacktrace import CallStack
 from crash.stacktrace import Stacktrace
 from libs.gitiles.diff import ChangeType
 
 
@@ skipping 163 matching lines @@
   dep_to_file_to_changelogs = defaultdict(lambda: defaultdict(list))
   reverted_cls = set()
 
   for dep in stack_deps:
     # If a dep is not in regression range, than it cannot be the dep of
     # culprits.
     dep_roll = regression_deps_rolls.get(dep)
     if not dep_roll:
       continue
 
-    dep_roll = regression_deps_rolls[dep]
-
     repository.repo_url = dep_roll.repo_url
     changelogs = repository.GetChangeLogs(dep_roll.old_revision,
                                           dep_roll.new_revision)
 
-    if not changelogs:
-      continue
-
-    for changelog in changelogs:
+    for changelog in changelogs or []:
       # When someone reverts, we need to skip both the CL doing
       # the reverting as well as the CL that got reverted. If
       # ``reverted_revision`` is true, then this CL reverts another one,
       # so we skip it and save the CL it reverts in ``reverted_cls`` to
       # be filtered out later.
       if changelog.reverted_revision:
         reverted_cls.add(changelog.reverted_revision)
         continue
 
       for touched_file in changelog.touched_files:
@@ skipping 31 matching lines @@
     }
   """
   dep_to_file_to_stack_infos = defaultdict(lambda: defaultdict(list))
 
   for callstack in stacktrace:
     for frame in callstack:
       # We only care about those dependencies in crash stack.
       if frame.dep_path not in stack_deps:
         continue
 
-      dep_to_file_to_stack_infos[frame.dep_path][frame.file_path].append((
-          frame, callstack.priority))
+      dep_to_file_to_stack_infos[frame.dep_path][frame.file_path].append(
+          StackInfo(frame, callstack.priority))
 
   return dep_to_file_to_stack_infos
 
 
 # TODO(katesonia): Remove the repository argument after refatoring cl committed.
 def FindSuspects(dep_to_file_to_changelogs,
                  dep_to_file_to_stack_infos,
                  stack_deps, repository,
                  ignore_cls=None):
   """Finds suspects by matching stacktrace and changelogs in regression range.
@@ skipping 27 matching lines @@
         repository.repo_url = stack_deps[dep].repo_url
         blame = repository.GetBlame(touched_file_path,
                                     stack_deps[dep].revision)
 
         # Generate/update each suspect(changelog) in changelogs, blame is used
         # to calculate distance between touched lines and crashed lines in file.
         suspects.GenerateSuspects(
             touched_file_path, dep, stack_infos, changelogs, blame)
 
   return suspects.values()