Remove PlatformCanvas::GetBitmapContext()

Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org

Committed: https://crrev.com/6b76da0d5e4f1e1aa75329a53a772de6e96b227b
Cr-Commit-Position: refs/heads/master@{#441127}

[f(malita), 2016-12-28 15:28:02]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 15:28:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-12-28 15:30:05]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2016-12-28 15:43:15]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 15:43:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-12-28 15:48:16]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 15:48:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-12-28 16:18:03]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

WIP

BUG=
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

WIP

BUG=675977
R=reed@google.com
==========

[f(malita), 2016-12-28 16:18:03]

fmalita@chromium.org changed reviewers:
+ reed@google.com

[f(malita), 2016-12-28 16:21:49]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

WIP

BUG=675977
R=reed@google.com
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and the now-useless platform_device_foo stubs.

BUG=675977
R=reed@google.com
==========

[f(malita), 2016-12-28 16:22:25]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and the now-useless platform_device_foo stubs.

BUG=675977
R=reed@google.com
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
==========

[commit-bot: I haz the power, 2016-12-28 16:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 16:48:26]

Dry run: This issue passed the CQ dry run.

[reed1, 2017-01-01 19:40:57]

lgtm

[f(malita), 2017-01-03 14:22:41]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org
==========

[f(malita), 2017-01-03 14:22:41]

fmalita@chromium.org changed reviewers:
+ danakj@chromium.org

[f(malita), 2017-01-03 14:23:18]

TBR danakj@ for minor ui/gfx change.

[f(malita), 2017-01-03 14:23:22]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-01-03 14:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 15:30:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483453402719370,
"parent_rev": "cdceb23685afdf5b747910e1cf740748a7f1c272", "commit_rev":
"ce58b2ba363a5bd7b59692082e15d38527f5ed2c"}

[commit-bot: I haz the power, 2017-01-03 15:30:35]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2607603004
==========

[commit-bot: I haz the power, 2017-01-03 15:30:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-03 15:34:55]

Description was changed from

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2607603004
==========

to

==========
Remove PlatformCanvas::GetBitmapContext()

This API is only used from ~CanvasSkiaPaint(), and is similar in behavior
to ScopedPlatformPaint::GetNativeDrawingContext().

Refactor the only client to use the latter, get rid of the GetBitmapContext()
virtual and platform_device_foo stubs.

BUG=675977
R=reed@google.com
TBR=danakj@chromium.org

Committed: https://crrev.com/6b76da0d5e4f1e1aa75329a53a772de6e96b227b
Cr-Commit-Position: refs/heads/master@{#441127}
==========

[commit-bot: I haz the power, 2017-01-03 15:34:56]

Patchset 3 (id:??) landed as
https://crrev.com/6b76da0d5e4f1e1aa75329a53a772de6e96b227b
Cr-Commit-Position: refs/heads/master@{#441127}