Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2607603003:
[ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper (Closed)
|
Created:
3 years, 12 months ago by leonhsl(Using Gerrit) Modified:
3 years, 11 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper
BUG=
Committed: https://crrev.com/196b024883ce2d95a82f375af1c36d76408945a6
Cr-Commit-Position: refs/heads/master@{#440927}
Patch Set 1 #
Total comments: 4
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
leon.han@intel.com changed reviewers: + falken@chromium.org
A small contribution:) Would you PTAL? Thanks.
lgtm Can you give a more specific commit description like: "Remove some unused code from EmbeddedWorkerTestHelper" https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... File content/browser/service_worker/embedded_worker_test_helper.h (left): https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... content/browser/service_worker/embedded_worker_test_helper.h:31: #include "testing/gtest/include/gtest/gtest.h" Doesn't look right to remove gtest.h
nhiroki@chromium.org changed reviewers: + nhiroki@chromium.org
lgtm https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... File content/browser/service_worker/embedded_worker_test_helper.cc (left): https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... content/browser/service_worker/embedded_worker_test_helper.cc:25: #include "content/common/service_worker/service_worker_event_dispatcher.mojom.h" It looks like this is still used for ServiceWorkerEventDispatcherRequest.
https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... File content/browser/service_worker/embedded_worker_test_helper.cc (left): https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... content/browser/service_worker/embedded_worker_test_helper.cc:25: #include "content/common/service_worker/service_worker_event_dispatcher.mojom.h" On 2016/12/28 09:56:05, nhiroki (OOO until Jan 5) wrote: > It looks like this is still used for ServiceWorkerEventDispatcherRequest. Ah sorry, this is already included in the header file :p
Description was changed from ========== [ServiceWorker] Some codes cleanup BUG= ========== to ========== [ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper BUG= ==========
Updated CL's title and description, and supposing falken@ is OOO, let me send this to CQ now. Thanks. https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... File content/browser/service_worker/embedded_worker_test_helper.h (left): https://codereview.chromium.org/2607603003/diff/1/content/browser/service_wor... content/browser/service_worker/embedded_worker_test_helper.h:31: #include "testing/gtest/include/gtest/gtest.h" On 2016/12/28 09:54:09, falken (ooo happy new year) wrote: > Doesn't look right to remove gtest.h Seems embedded_worker_test_helper.h does not use anything defined in gtest.h, so I removed it, and embedded_worker_test_helper.cc is including gtest.h.
The CQ bit was checked by leon.han@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482978854331320, "parent_rev":
"45deb48f70797610e1049ad31bb7182bc97d3727", "commit_rev":
"6d672766d6f29d34bce20d1e108efb4699a0fb3b"}
Message was sent while issue was closed.
Description was changed from ========== [ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper BUG= ========== to ========== [ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper BUG= Review-Url: https://codereview.chromium.org/2607603003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper BUG= Review-Url: https://codereview.chromium.org/2607603003 ========== to ========== [ServiceWorker] Remove some unused code from EmbeddedWorkerTestHelper BUG= Committed: https://crrev.com/196b024883ce2d95a82f375af1c36d76408945a6 Cr-Commit-Position: refs/heads/master@{#440927} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/196b024883ce2d95a82f375af1c36d76408945a6 Cr-Commit-Position: refs/heads/master@{#440927} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
