Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971
Committed: https://crrev.com/51accc46a09dfc282f23672b0385b57948a5ff30
Cr-Commit-Position: refs/heads/master@{#440845}

[Thiemo Nagel, 2016-12-27 18:45:49]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 18:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-12-27 19:22:54]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-12-27 19:23:45]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:24:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-12-27 19:24:12]

tnagel@chromium.org changed reviewers:
+ rsorokin@chromium.org

[Thiemo Nagel, 2016-12-27 19:24:13]

Hi Roman,

could you please take a look at chromeos/dbus/*?

Thank you,
Thiemo

[Thiemo Nagel, 2016-12-27 19:24:46]

tnagel@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Thiemo Nagel, 2016-12-27 19:24:46]

Hi Steven,

could you please take a look at BUILD.gn?

Thank you,
Thiemo

[stevenjb, 2016-12-27 19:40:41]

Clarify the description to say 'Add Fake implementation for...'

(Strictly speaking the Fake implementation doesn't really have anything to do
with Linux, that's just where we tend to use it).

[stevenjb, 2016-12-27 19:40:48]

LGTM

[Thiemo Nagel, 2016-12-27 19:42:27]

Description was changed from

==========
Add Linux stub for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971
==========

to

==========
Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971
==========

[Thiemo Nagel, 2016-12-27 19:43:04]

On 2016/12/27 19:40:41, stevenjb wrote:
> Clarify the description to say 'Add Fake implementation for...'
> 
> (Strictly speaking the Fake implementation doesn't really have anything to do
> with Linux, that's just where we tend to use it).

Thanks, that makes sense.

[commit-bot: I haz the power, 2016-12-27 20:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:14:15]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2016-12-28 10:29:38]

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
File chromeos/dbus/fake_auth_policy_client.cc (right):

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:31: const std::string& policy_type) {
Maybe add 
DCHECK(base::WorkerPool::GetTaskRunner(false /* task_is_slow
*/)->RunsTasksOnCurrentThread());

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:117: em::CloudPolicySettings policy;
Do we write just an empty policy?

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:119:
policy.SerializeToString(&payload);
Should we check for result here?

[Thiemo Nagel, 2016-12-28 11:08:15]

Patchset #3 (id:40001) has been deleted

[Thiemo Nagel, 2016-12-28 11:08:21]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 11:08:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-12-28 11:08:59]

Thank you!  Could you please take another look?

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
File chromeos/dbus/fake_auth_policy_client.cc (right):

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:31: const std::string& policy_type) {
On 2016/12/28 10:29:38, Roman Sorokin wrote:
> Maybe add 
> DCHECK(base::WorkerPool::GetTaskRunner(false /* task_is_slow
> */)->RunsTasksOnCurrentThread());

I don't think this is necessary as the file operations blow up anyways if
they're run on the wrong thread.

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:117: em::CloudPolicySettings policy;
On 2016/12/28 10:29:38, Roman Sorokin wrote:
> Do we write just an empty policy?

Yes.  I'm reluctant writing actual policy values because it might interfere with
tests or create confusion in some other way.

https://codereview.chromium.org/2607593002/diff/20001/chromeos/dbus/fake_auth...
chromeos/dbus/fake_auth_policy_client.cc:119:
policy.SerializeToString(&payload);
On 2016/12/28 10:29:38, Roman Sorokin wrote:
> Should we check for result here?

I've added CHECK()s.

[Roman Sorokin (ftl), 2016-12-28 11:14:01]

lgtm

[Thiemo Nagel, 2016-12-28 11:22:28]

The CQ bit was unchecked by tnagel@chromium.org

[Thiemo Nagel, 2016-12-28 11:22:35]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-12-28 11:22:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2607593002/#ps60001
(title: "CHECK on serialization errors")

[commit-bot: I haz the power, 2016-12-28 11:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 12:01:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482924155359170,
"parent_rev": "e2104de7aa63008f7af04a153d071a1ec5cbf875", "commit_rev":
"1cd14a38d991714ebe4f158726591d25c0ff1a3d"}

[commit-bot: I haz the power, 2016-12-28 12:01:26]

Description was changed from

==========
Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971
==========

to

==========
Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971

Review-Url: https://codereview.chromium.org/2607593002
==========

[commit-bot: I haz the power, 2016-12-28 12:01:27]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2017-01-02 15:48:54]

Description was changed from

==========
Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971

Review-Url: https://codereview.chromium.org/2607593002
==========

to

==========
Add fake implementation for AuthPolicyClient::RefreshUserPolicy()

Also switch from std::string to AccountId argument for
RefreshUserPolicy().

BUG=655971

Committed: https://crrev.com/51accc46a09dfc282f23672b0385b57948a5ff30
Cr-Commit-Position: refs/heads/master@{#440845}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:55]

Patchset 3 (id:??) landed as
https://crrev.com/51accc46a09dfc282f23672b0385b57948a5ff30
Cr-Commit-Position: refs/heads/master@{#440845}