Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2607523002: Reading List: Open distilled article first if no network. (Closed)

Created:
3 years, 12 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
gambard
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reading List: Open distilled article first if no network. If there is no network connection, the read next gesture should open the first distilled article if some exists. This is case A1 of attached bug. BUG=669897 Committed: https://crrev.com/66054aa99313bd7dae16a8f0bce0f19d53d00cec Cr-Commit-Position: refs/heads/master@{#440752}

Patch Set 1 #

Patch Set 2 : add guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M components/reading_list/ios/reading_list_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Olivier
3 years, 12 months ago (2016-12-27 11:01:15 UTC) #2
gambard
lgtm
3 years, 12 months ago (2016-12-27 11:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607523002/20001
3 years, 12 months ago (2016-12-27 12:35:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-27 12:48:06 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66054aa99313bd7dae16a8f0bce0f19d53d00cec
Cr-Commit-Position: refs/heads/master@{#440752}

Powered by Google App Engine
This is Rietveld 408576698