Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2607513002: Remove Render.Workers.MaxWorkerCountInRendererProcess UMA. (Closed)

Created:
3 years, 12 months ago by falken
Modified:
3 years, 11 months ago
Reviewers:
kinuko, Steven Holte
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Render.Workers.MaxWorkerCountInRendererProcess UMA. This UMA and code is misleading because the shared worker ref count in RenderProcessHostImpl actually is not the number of running shared workers. We've added comments since that clarify it. If we want this UMA back we can add a new one later. I'll add current stats to the bug. BUG=403258 Committed: https://crrev.com/3616a4304d02fdaba982fc443ed8b908cf786e78 Cr-Commit-Position: refs/heads/master@{#440951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +5 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
falken
kinuko@ can you review this? This has bothered me a bit since I learned about ...
3 years, 12 months ago (2016-12-27 08:05:10 UTC) #2
kinuko
Yes, lgtm. Thanks for clarifying!
3 years, 12 months ago (2016-12-27 15:39:17 UTC) #7
falken
holte: can you review histograms?
3 years, 11 months ago (2016-12-28 01:53:27 UTC) #9
falken
holte: can you review histograms?
3 years, 11 months ago (2016-12-28 01:53:27 UTC) #10
Steven Holte
histograms lgtm
3 years, 11 months ago (2016-12-28 19:45:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607513002/1
3 years, 11 months ago (2016-12-29 10:58:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 11:54:29 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:08 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3616a4304d02fdaba982fc443ed8b908cf786e78
Cr-Commit-Position: refs/heads/master@{#440951}

Powered by Google App Engine
This is Rietveld 408576698