Issue 26075002: Revert 227100 "Track active references in ShillClientHelper (Tak..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26075002: Revert 227100 "Track active references in ShillClientHelper (Tak..." (Closed)

Created:
7 years, 2 months ago by stevenjb

Modified:
7 years, 2 months ago

Reviewers:
stevenjb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 227100 "Track active references in ShillClientHelper (Tak..." > Track active references in ShillClientHelper (Take 2) > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > Original CL: https://codereview.chromium.org/23658053/ > > BUG=223483 > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/24558004 Failure: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64%29%20ASAN/builds/6931 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227139

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -142 lines)			Patch
M	trunk/src/chromeos/dbus/shill_client_helper.h	View	5 chunks	+1 line, -20 lines	0 comments	Download
M	trunk/src/chromeos/dbus/shill_client_helper.cc	View	23 chunks	+21 lines, -84 lines	0 comments	Download
M	trunk/src/chromeos/dbus/shill_device_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chromeos/dbus/shill_ipconfig_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chromeos/dbus/shill_manager_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chromeos/dbus/shill_profile_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chromeos/dbus/shill_service_client.cc	View	3 chunks	+3 lines, -32 lines	0 comments	Download
M	trunk/src/dbus/object_proxy.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r227139.