Issue 24558004: Track active references in ShillClientHelper (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24558004: Track active references in ShillClientHelper (Take 2) (Closed)

Created:
7 years, 2 months ago by stevenjb

Modified:
7 years, 2 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Track active references in ShillClientHelper (Take 2) To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Original CL: https://codereview.chromium.org/23658053/ BUG=223483 TBR=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227100

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -29 lines)			Patch
M	chromeos/dbus/shill_client_helper.h	View		5 chunks	+20 lines, -1 line	0 comments	Download
M	chromeos/dbus/shill_client_helper.cc	View		23 chunks	+84 lines, -21 lines	0 comments	Download
M	chromeos/dbus/shill_device_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/shill_ipconfig_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/shill_manager_client.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/shill_profile_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/shill_service_client.cc	View	1 2 3 4	3 chunks	+32 lines, -3 lines	0 comments	Download
M	dbus/object_proxy.h	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

stevenjb

7 years, 2 months ago (2013-10-04 21:51:04 UTC) #1

Message was sent while issue was closed.

Committed patchset #6 manually as r227100 (presubmit successful).