Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2607493002:
Hide keyboard before showing IME menu. (Closed)
DescriptionHide keyboard before showing IME menu.
BUG=677087
TEST=Verified on local build.
Committed: https://crrev.com/e2664490643d22ea8522af8225aa84b33554c99c
Cr-Commit-Position: refs/heads/master@{#440911}
Patch Set 1 #Patch Set 2 #Patch Set 3 #Patch Set 4 #
Messages
Total messages: 27 (20 generated)
Description was changed from ========== Hide keyboard when show IME menu. BUG=677087 TEST=Verified on local build. ========== to ========== Hide keyboard before showing IME menu. BUG=677087 TEST=Verified on local build. ==========
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
azurewei@chromium.org changed reviewers: + shuchen@chromium.org, tdanderson@chromium.org
Please review this CL. Thanks!
azurewei@chromium.org changed reviewers: + stevenjb@chromium.org - tdanderson@chromium.org
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by azurewei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shuchen@chromium.org Link to the patchset: https://codereview.chromium.org/2607493002/#ps60001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482971224503500,
"parent_rev": "f14b85fd001e27a62d38b86e4dabbbdbd70215a3", "commit_rev":
"6241bd8254fe942ea21f5ec386cfd755e826b3c2"}
Message was sent while issue was closed.
Description was changed from ========== Hide keyboard before showing IME menu. BUG=677087 TEST=Verified on local build. ========== to ========== Hide keyboard before showing IME menu. BUG=677087 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2607493002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Hide keyboard before showing IME menu. BUG=677087 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2607493002 ========== to ========== Hide keyboard before showing IME menu. BUG=677087 TEST=Verified on local build. Committed: https://crrev.com/e2664490643d22ea8522af8225aa84b33554c99c Cr-Commit-Position: refs/heads/master@{#440911} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e2664490643d22ea8522af8225aa84b33554c99c Cr-Commit-Position: refs/heads/master@{#440911} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
