Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 2607433002: bindings: Throw a TypeError when a given callback function isn't callable (Closed)

Created:
3 years, 12 months ago by bashi
Modified:
3 years, 12 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Throw a TypeError when a given callback function isn't callable According to the spec[1], we should throw a TypeError when a given callback function isn't callable. [1] https://heycam.github.io/webidl/#es-callback-function BUG=675859 Committed: https://crrev.com/1a82b63469d04db61a23921fa95ffa86ec9fd5ed Cr-Commit-Position: refs/heads/master@{#440698}

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
bashi
PTAL
3 years, 12 months ago (2016-12-26 08:29:26 UTC) #4
haraken
LGTM
3 years, 12 months ago (2016-12-26 08:32:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607433002/1
3 years, 12 months ago (2016-12-26 08:48:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-26 08:52:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a82b63469d04db61a23921fa95ffa86ec9fd5ed Cr-Commit-Position: refs/heads/master@{#440698}
3 years, 12 months ago (2016-12-26 08:55:09 UTC) #14
Yuki
3 years, 12 months ago (2016-12-26 09:09:18 UTC) #15
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698