components/password_manager/core/browser/password_manager_metrics_util.h - Issue 2607413003: Add security feature to ProvisionalSavePassword

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2607413003: Add security feature to ProvisionalSavePassword (Closed)

Patch Set: Addressed nit. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/browser/password_manager_metrics_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index 9582c882ea4cb4aa60fe8a68dfc5777a711bdc9a..c2377f1f7c221f4bd25c5769ac7450054fa66bca 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -216,6 +216,9 @@ void LogAccountChooserUserActionManyAccounts(AccountChooserUserAction action);

// Log a user action on showing the Chrome sign in promo.

void LogSyncSigninPromoUserAction(SyncSignInUserAction action);

+// Logs whether a password was rejected due to same origin but different scheme.

+void LogShouldBlockPasswordForSameOriginButDifferentScheme(bool should_block);

// Log if the account chooser has empty username or duplicate usernames.

void LogAccountChooserUsability(AccountChooserUsabilityMetric usability);