components/password_manager/core/browser/password_manager_metrics_util.cc - Issue 2607413003: Add security feature to ProvisionalSavePassword

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.cc

Issue 2607413003: Add security feature to ProvisionalSavePassword (Closed)

Patch Set: Addressed nit. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_metrics_util.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.cc

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc

index 7b55d8d12f7144d3e30d68fef8803ddaf3a74c7b..8bc566bc844a64ad1b5c61ad5a8ebbff77c82662 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.cc

+++ b/components/password_manager/core/browser/password_manager_metrics_util.cc

@@ -104,6 +104,12 @@ void LogSyncSigninPromoUserAction(SyncSignInUserAction action) {

CHROME_SIGNIN_ACTION_COUNT);

}

+void LogShouldBlockPasswordForSameOriginButDifferentScheme(bool should_block) {

+ UMA_HISTOGRAM_BOOLEAN(

+ "PasswordManager.ShouldBlockPasswordForSameOriginButDifferentScheme",

+ should_block);

void LogAccountChooserUsability(AccountChooserUsabilityMetric usability) {

UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialogUsability",

usability, ACCOUNT_CHOOSER_USABILITY_COUNT);