Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)
Patch Set: fix comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
index 84464d11f15431bec476dca7f8fa2fcdc74d0890..b1a6cc0b9bbdb96df5f956537ce314a07c5c891f 100644
--- a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
@@ -89,13 +89,14 @@ TEST_F(VisiblePositionTest, NonNullInvalidatedAfterStyleChange) {
Position position(paragraph->firstChild(), 1);
VisiblePosition visiblePosition1 = createVisiblePosition(position);
- div->style()->setProperty("color", "red", "important", ASSERT_NO_EXCEPTION);
+ div->style()->setProperty(nullptr, "color", "red", "important",
+ ASSERT_NO_EXCEPTION);
EXPECT_FALSE(visiblePosition1.isValid());
updateAllLifecyclePhases();
VisiblePosition visiblePosition2 = createVisiblePosition(position);
- div->style()->setProperty("display", "none", "important",
+ div->style()->setProperty(nullptr, "display", "none", "important",
ASSERT_NO_EXCEPTION);
EXPECT_FALSE(visiblePosition2.isValid());

Powered by Google App Engine
This is Rietveld 408576698