Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)
Patch Set: fix comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/editing/VisiblePosition.h" 5 #include "core/editing/VisiblePosition.h"
6 6
7 #include "core/css/CSSStyleDeclaration.h" 7 #include "core/css/CSSStyleDeclaration.h"
8 #include "core/editing/EditingTestBase.h" 8 #include "core/editing/EditingTestBase.h"
9 #include "core/editing/VisibleUnits.h" 9 #include "core/editing/VisibleUnits.h"
10 10
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 } 82 }
83 83
84 TEST_F(VisiblePositionTest, NonNullInvalidatedAfterStyleChange) { 84 TEST_F(VisiblePositionTest, NonNullInvalidatedAfterStyleChange) {
85 setBodyContent("<div>one</div><p>two</p>"); 85 setBodyContent("<div>one</div><p>two</p>");
86 86
87 Element* paragraph = document().querySelector("p"); 87 Element* paragraph = document().querySelector("p");
88 Element* div = document().querySelector("div"); 88 Element* div = document().querySelector("div");
89 Position position(paragraph->firstChild(), 1); 89 Position position(paragraph->firstChild(), 1);
90 90
91 VisiblePosition visiblePosition1 = createVisiblePosition(position); 91 VisiblePosition visiblePosition1 = createVisiblePosition(position);
92 div->style()->setProperty("color", "red", "important", ASSERT_NO_EXCEPTION); 92 div->style()->setProperty(nullptr, "color", "red", "important",
93 ASSERT_NO_EXCEPTION);
93 EXPECT_FALSE(visiblePosition1.isValid()); 94 EXPECT_FALSE(visiblePosition1.isValid());
94 95
95 updateAllLifecyclePhases(); 96 updateAllLifecyclePhases();
96 97
97 VisiblePosition visiblePosition2 = createVisiblePosition(position); 98 VisiblePosition visiblePosition2 = createVisiblePosition(position);
98 div->style()->setProperty("display", "none", "important", 99 div->style()->setProperty(nullptr, "display", "none", "important",
99 ASSERT_NO_EXCEPTION); 100 ASSERT_NO_EXCEPTION);
100 EXPECT_FALSE(visiblePosition2.isValid()); 101 EXPECT_FALSE(visiblePosition2.isValid());
101 102
102 updateAllLifecyclePhases(); 103 updateAllLifecyclePhases();
103 104
104 // Invalid VisiblePosition can never become valid again. 105 // Invalid VisiblePosition can never become valid again.
105 EXPECT_FALSE(visiblePosition1.isValid()); 106 EXPECT_FALSE(visiblePosition1.isValid());
106 EXPECT_FALSE(visiblePosition2.isValid()); 107 EXPECT_FALSE(visiblePosition2.isValid());
107 } 108 }
108 109
109 #endif 110 #endif
110 111
111 } // namespace blink 112 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698