third_party/WebKit/Source/core/css/DOMWindowCSS.cpp - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: fix comments Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

diff --git a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

index c1196921398871840477101b6e00af728e1a4ede..46c90a4218e188aefb0c9d833db582802b0000e9 100644

--- a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

+++ b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

@@ -46,8 +46,9 @@ bool DOMWindowCSS::supports(const String& property, const String& value) {

MutableStylePropertySet* dummyStyle =

MutableStylePropertySet::create(HTMLStandardMode);

bool isAnimationTainted = false;

- return CSSParser::parseValueForCustomProperty(

- dummyStyle, "--valid", value, false, nullptr, isAnimationTainted)

+ return CSSParser::parseValueForCustomProperty(dummyStyle, "--valid",

+ nullptr, value, false,

+ nullptr, isAnimationTainted)

.didParse;

}