third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: fix comments Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/DOMWindowCSS.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

diff --git a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

index 630aea05009f1dbaef3ba42e49a8107af367189b..4621a070373caf73154b830c811476886719bd2e 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

+++ b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

@@ -31,7 +31,7 @@

DOMString getPropertyPriority(DOMString property);

// TODO(foolip): The value and priority arguments should have

// [TreatNullAs=EmptyString] and should not be nullable.

- [CEReactions, RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);

+ [CallWith=ExecutionContext, CEReactions, RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);

// void setPropertyValue(DOMString property, [TreatNullAs=EmptyString] DOMString value);

// void setPropertyPriority(DOMString property, [TreatNullAs=EmptyString] DOMString priority);

[CEReactions, RaisesException] DOMString removeProperty(DOMString property);

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/DOMWindowCSS.cpp » ('j') | no next file with comments »