third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

index af1227e168e16b0df4a9f85b3851f6fc0c07827a..fc61883728394dc231b7eda78d72d0e7b16c8fdd 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

@@ -118,8 +118,8 @@ String createShorthandValue(Document* document,

CSSStyleRule* rule = toCSSStyleRule(styleSheet->item(0));

CSSStyleDeclaration* style = rule->style();

DummyExceptionStateForTesting exceptionState;

- style->setProperty(longhand, newValue, style->getPropertyPriority(longhand),

- exceptionState);

+ style->setProperty(nullptr, longhand, newValue,

+ style->getPropertyPriority(longhand), exceptionState);

return style->getPropertyValue(shorthand);

}