Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index d7adbbbb1db85b666a3afa85f0f9c5fc3fc1163a..a3ac691deb3bb8917b67a2da4aff2b6a5a51d1dd 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -1295,6 +1295,7 @@ class CORE_EXPORT Document : public ContainerNode,
void maybeRecordLoadReason(WouldLoadReason);
WouldLoadReason wouldLoadReason() { return m_wouldLoadReason; }
+ const PropertyRegistry* propertyRegistry() const;
PropertyRegistry* propertyRegistry();
// Indicates whether the user has interacted with this particular Document.
@@ -1664,7 +1665,7 @@ class CORE_EXPORT Document : public ContainerNode,
WouldLoadReason m_wouldLoadReason;
- Member<PropertyRegistry> m_propertyRegistry;
+ mutable Member<PropertyRegistry> m_propertyRegistry;
alancutter (OOO until 2018) 2017/01/04 01:03:42 Why is this mutable?
Timothy Loh 2017/01/04 02:00:59 Oops, I was going to copy the logic in non-const p
alancutter (OOO until 2018) 2017/01/04 02:22:10 I don't think mutable is required for your origina
unsigned m_passwordCount;

Powered by Google App Engine
This is Rietveld 408576698