Disallow setting invalid values for registered properties via CSSOM

third_party/WebKit/Source/core/dom/Document.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 1277 matching lines @@
   RootScrollerController& rootScrollerController() const {
     DCHECK(m_rootScrollerController);
     return *m_rootScrollerController;
   }
 
   bool isInMainFrame() const;
 
   void maybeRecordLoadReason(WouldLoadReason);
   WouldLoadReason wouldLoadReason() { return m_wouldLoadReason; }
 
+  const PropertyRegistry* propertyRegistry() const;
   PropertyRegistry* propertyRegistry();
 
   // Indicates whether the user has interacted with this particular Document.
   void setHasReceivedUserGesture() { m_hasReceivedUserGesture = true; }
   bool hasReceivedUserGesture() const { return m_hasReceivedUserGesture; }
 
   // Document maintains a counter of visible non-secure password
   // fields in the page. Used to notify the embedder when all visible
   // non-secure passwords fields are no longer visible.
   void incrementPasswordCount();
@@ skipping 349 matching lines @@
   Member<ResizeObserverController> m_resizeObserverController;
 
   int m_nodeCount;
 
   bool m_mayContainV0Shadow = false;
 
   Member<SnapCoordinator> m_snapCoordinator;
 
   WouldLoadReason m_wouldLoadReason;
 
-  Member<PropertyRegistry> m_propertyRegistry;
+  mutable Member<PropertyRegistry> m_propertyRegistry;

[alancutter (OOO until 2018), 2017/01/04 01:03:42]

Why is this mutable?

[Timothy Loh, 2017/01/04 02:00:59]

Oops, I was going to copy the logic in non-const propertyRegistry to the const
one, but then I just const_cast'd and called the non-const. Will remove.

[alancutter (OOO until 2018), 2017/01/04 02:22:10]

I don't think mutable is required for your original plan anyway. (:

 
   unsigned m_passwordCount;
 
   TaskHandle m_sensitiveInputVisibilityTask;
 
   mojom::EngagementLevel m_engagementLevel;
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Document>;
 
@@ skipping 40 matching lines @@
 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
 
 }  // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 CORE_EXPORT void showLiveDocumentInstances();
 #endif
 
 #endif  // Document_h