Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2607353002: WindowAudioWorklet: gracefully handle detached use. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WindowAudioWorklet: gracefully handle detached use. R=haraken BUG=677612 Committed: https://crrev.com/f58d96c9f38bcbd1e40230340035a1b47216f9cc Cr-Commit-Position: refs/heads/master@{#441094}

Patch Set 1 #

Patch Set 2 : static version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-02 19:09:48 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-03 01:12:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607353002/20001
3 years, 11 months ago (2017-01-03 06:10:46 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 06:15:31 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 06:18:22 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f58d96c9f38bcbd1e40230340035a1b47216f9cc
Cr-Commit-Position: refs/heads/master@{#441094}

Powered by Google App Engine
This is Rietveld 408576698