Add mac clang toolchains required for V8 cross compiling

Add mac clang toolchains required for V8 cross compiling

BUG=none
R=machenbach@chromium.org,dpranke@chromium.org

Committed: https://crrev.com/4596f9dac41a269f19eb8bc999a67d6b552a15bb
Cr-Commit-Position: refs/heads/master@{#441337}

[jochen (gone - plz use gerrit), 2017-01-02 11:12:07]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 11:12:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 12:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 12:20:52]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-01-04 02:38:46]

lgtm

[jochen (gone - plz use gerrit), 2017-01-04 06:55:26]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:55:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 07:59:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483512926236940, "parent_rev":
"0f8e22bcfb2d999a5741d676daf6e945bad5d376", "commit_rev":
"3d5689164aa404f926cc961bf9e7e9f78db9235c"}

[commit-bot: I haz the power, 2017-01-04 07:59:27]

Description was changed from

==========
Add mac clang toolchains required for V8 cross compiling

BUG=none
R=machenbach@chromium.org,dpranke@chromium.org
==========

to

==========
Add mac clang toolchains required for V8 cross compiling

BUG=none
R=machenbach@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2607323002
==========

[commit-bot: I haz the power, 2017-01-04 07:59:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 08:02:33]

Description was changed from

==========
Add mac clang toolchains required for V8 cross compiling

BUG=none
R=machenbach@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2607323002
==========

to

==========
Add mac clang toolchains required for V8 cross compiling

BUG=none
R=machenbach@chromium.org,dpranke@chromium.org

Committed: https://crrev.com/4596f9dac41a269f19eb8bc999a67d6b552a15bb
Cr-Commit-Position: refs/heads/master@{#441337}
==========

[commit-bot: I haz the power, 2017-01-04 08:02:34]

Patchset 1 (id:??) landed as
https://crrev.com/4596f9dac41a269f19eb8bc999a67d6b552a15bb
Cr-Commit-Position: refs/heads/master@{#441337}

[Michael Achenbach, 2017-01-04 13:09:16]

lgtm

[Nico, 2017-08-09 20:34:10]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-08-09 20:34:11]

Cross-compiling from where to where?

(please either have tracking bugs or somewhat more descriptive CL descriptions
for stuff like this :-/)

[jochen (gone - plz use gerrit), 2017-08-21 12:29:38]

On 2017/08/09 at 20:34:11, thakis wrote:
> Cross-compiling from where to where?
> 
> (please either have tracking bugs or somewhat more descriptive CL descriptions
for stuff like this :-/)

I thought the toolchain names are pretty descriptive... from x86/x64 to
arm/mips. It's also the normal pattern used to name toolchains in gn

[Nico, 2017-08-21 17:27:44]

I understand what the toolchains do, I don't understand what they're here
for. (We don't ship 32-bit chrome/mac binaries, and no mips.)

From the cc list I'm guessing this is for some cross build of v8, but I
don't know much about v8. Do you support targeting all of your target archs
from all of your hosts? Do you have docs on how long you intend to keep
32-bit builds around? etc.

(Concretely, I'm happy about this change because it makes it easier to
build 32-bit chrome/win on mac, but I'm wondering how long this will stay
around, and I was wondering why this change was made. Ideally the CL
description would've told me.)

On Mon, Aug 21, 2017 at 8:29 AM, <jochen@chromium.org> wrote:

> On 2017/08/09 at 20:34:11, thakis wrote:
> > Cross-compiling from where to where?
> >
> > (please either have tracking bugs or somewhat more descriptive CL
> descriptions
> for stuff like this :-/)
>
> I thought the toolchain names are pretty descriptive... from x86/x64 to
> arm/mips. It's also the normal pattern used to name toolchains in gn
>
> https://codereview.chromium.org/2607323002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2017-08-21 17:36:19]

We do ship mips (or mipsel to be precise), it's a fully supported chrome
platform (because it's a fully supported Android platform).

These toolchains here, however, are used for testing only: v8_$arch means that
v8 uses a CPU simulator for that arch. The only requirement is that the host
arch has the same bitwidth.

As they're required for v8 development, they're here to stay. On the waterfall,
we only run Linux builders for those...

If I had filed a tracking bug I probably wouldn't have explained that either,
but it would most likely have stated something like "make it possible to compile
v8 on Mac".