Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

The following traits are used to post a task to TaskScheduler
from this file:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
Review-Url: https://codereview.chromium.org/2607273002
Cr-Commit-Position: refs/heads/master@{#441681}
Committed: https://chromium.googlesource.com/chromium/src/+/9be76765fef84481195dd96339c8fa011257f402

[fdoray, 2016-12-31 19:34:00]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 19:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-31 19:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 19:36:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fdoray, 2016-12-31 19:49:10]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

The following traits are used to post a task to TaskScheduler
from this file:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

The following traits are used to post a task to TaskScheduler
from this file:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

[fdoray, 2016-12-31 20:08:07]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 20:08:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-31 20:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 20:22:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-01-01 18:43:43]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-01 18:43:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-01 19:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-01 19:15:48]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-01-01 19:31:39]

fdoray@chromium.org changed reviewers:
+ hashimoto@chromium.org

[fdoray, 2017-01-01 19:31:39]

PTAL. WorkerPool is being deprecated in favor of TaskScheduler.

[hashimoto, 2017-01-05 05:00:24]

qq: Should we use BACKGROUND whenever it's acceptable? By default, the priority
of a task which is posted from the UI thread is always USER_BLOCKING?

lgtm

[fdoray, 2017-01-05 16:38:43]

On 2017/01/05 05:00:24, hashimoto wrote:
> qq: Should we use BACKGROUND whenever it's acceptable? By default, the
priority
> of a task which is posted from the UI thread is always USER_BLOCKING?
> 
> lgtm

Yes, we should use BACKGROUND whenever it's acceptable. The more BACKGROUND
tasks we have, the faster non-BACKGROUND tasks will be scheduled :)

Tasks posted without an explicit .WithPriority() trait inherit their priority
from the calling context. The priority of the calling context is USER_VISIBLE
outside of TaskScheduler. Inside TaskScheduler, the priority of the calling
context is the priority with which the currently running task was posted.

[fdoray, 2017-01-05 16:38:50]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 17:17:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483634330837980,
"parent_rev": "e199d6993db574a00ccaffdd3a292347bd10e752", "commit_rev":
"9be76765fef84481195dd96339c8fa011257f402"}

[commit-bot: I haz the power, 2017-01-05 17:17:56]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

The following traits are used to post a task to TaskScheduler
from this file:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc.

The following traits are used to post a task to TaskScheduler
from this file:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2607273002
Cr-Commit-Position: refs/heads/master@{#441681}
Committed:
https://chromium.googlesource.com/chromium/src/+/9be76765fef84481195dd96339c8...
==========

[commit-bot: I haz the power, 2017-01-05 17:17:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9be76765fef84481195dd96339c8...