Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2607233002: [builtins] Add EmitFastNewObject (Closed)

Created:
3 years, 11 months ago by gsathya
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Add EmitFastNewObject This refactors the logic from within the FastNewObject TF_BUILTIN to a helper method which can be reused in other assemblers. This saves the overhead of setting up the stub and calling into it. A wrapper method is created for functions that don't need to tail call into the runtime. PromiseBuiltinsAssembler and RegexpBuiltinsAssembler are refactored to use EmitFastNewObject. Review-Url: https://codereview.chromium.org/2607233002 Cr-Commit-Position: refs/heads/master@{#42000} Committed: https://chromium.googlesource.com/v8/v8/+/2077b314d5d5632da29262f610cd70c3c9536515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -17 lines) Patch
M src/builtins/builtins-constructor.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 4 chunks +41 lines, -11 lines 0 comments Download
M src/builtins/builtins-promise.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
gsathya
wdyt? worth it?
3 years, 11 months ago (2016-12-30 09:19:14 UTC) #5
mvstanton
I think it's good to eliminate a stub call. I'm happy to give LGTM Thanks! ...
3 years, 11 months ago (2016-12-30 10:20:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607233002/1
3 years, 11 months ago (2016-12-30 10:28:04 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2016-12-30 10:29:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2077b314d5d5632da29262f610cd70c3c95...

Powered by Google App Engine
This is Rietveld 408576698