Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: test/mjsunit/es6/debug-promises-caught-late.js

Issue 260723002: Trigger exception debug event for promises at the throw site. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/debug-promises-caught-late.js
diff --git a/test/mjsunit/es6/debug-promises-caught-uncaught.js b/test/mjsunit/es6/debug-promises-caught-late.js
similarity index 72%
copy from test/mjsunit/es6/debug-promises-caught-uncaught.js
copy to test/mjsunit/es6/debug-promises-caught-late.js
index b7f6d48196e436d77fc0e1f68fa7de19e26ff8c7..66e073d4a3cc5e5888d73fef51b73984c72886c9 100644
--- a/test/mjsunit/es6/debug-promises-caught-uncaught.js
+++ b/test/mjsunit/es6/debug-promises-caught-late.js
@@ -4,10 +4,9 @@
// Flags: --harmony-promises --expose-debug-as debug
-// Test debug events when we only listen to uncaught exceptions and
-// there is a catch handler for the exception thrown in a Promise.
-// Expectation:
-// - no debug event is triggered.
+// Test debug events when we only listen to uncaught exceptions, the Promise
+// throws, and a catch handler is installed right before throwing.
+// We expect no debug event to be triggered.
Debug = debug.Debug;
@@ -17,18 +16,15 @@ var p = new Promise(function(resolve, reject) {
var q = p.chain(
function() {
+ q.catch(function(e) {
+ assertEquals("caught", e.message);
+ });
throw new Error("caught");
});
-q.catch(
- function(e) {
- assertEquals("caught", e.message);
- });
-
function listener(event, exec_state, event_data, data) {
try {
assertTrue(event != Debug.DebugEvent.Exception);
- assertTrue(event != Debug.DebugEvent.PendingExceptionInPromise);
} catch (e) {
// Signal a failure with exit code 1. This is necessary since the
// debugger swallows exceptions and we expect the chained function

Powered by Google App Engine
This is Rietveld 408576698