Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2607193002:
Adding Short Record Header feature. (Closed)
DescriptionAdding Short Record Header feature.
BUG=677326
Review-Url: https://codereview.chromium.org/2607193002
Cr-Commit-Position: refs/heads/master@{#441965}
Committed: https://chromium.googlesource.com/chromium/src/+/2668d82b0edebec82ab5e4fc76e4aa65ff7efcd6
Patch Set 1 #Patch Set 2 : Fix syntax. #Patch Set 3 : Change name. #
Total comments: 2
Patch Set 4 : Add variations. #Messages
Total messages: 26 (19 generated)
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
svaldez@chromium.org changed reviewers: + davidben@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2607193002/diff/40001/net/socket/ssl_client_s... File net/socket/ssl_client_socket_impl.cc (right): https://codereview.chromium.org/2607193002/diff/40001/net/socket/ssl_client_s... net/socket/ssl_client_socket_impl.cc:222: #if defined(OS_NACL) Ooh, I guess we don't need to worry about build targets not explicitly initializing base::Feature anymore: https://chromium.googlesource.com/chromium/src/+/958f0473b8039a057b0e31412c2a... https://codereview.chromium.org/2607193002/diff/40001/net/socket/ssl_client_s... net/socket/ssl_client_socket_impl.cc:238: "SSLShortRecordHeader", base::FEATURE_DISABLED_BY_DEFAULT}; Should this go in testing/variations/fieldtrial_testing_config.json or something like the TLS 1.3 negotiation was? (To that end, I probably should have put SSLLegacyECDSACiphers in there. Oops.)
svaldez@chromium.org changed reviewers: + jwd@chromium.org
jwd: Could you take a look at fieldtest_testing_config.json.
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
(still lgtm)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by svaldez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483717903991060,
"parent_rev": "8ef7455cc93b4c724b4f72aa16dfc432609c1b77", "commit_rev":
"2668d82b0edebec82ab5e4fc76e4aa65ff7efcd6"}
Message was sent while issue was closed.
Description was changed from ========== Adding Short Record Header feature. BUG=677326 ========== to ========== Adding Short Record Header feature. BUG=677326 Review-Url: https://codereview.chromium.org/2607193002 Cr-Commit-Position: refs/heads/master@{#441965} Committed: https://chromium.googlesource.com/chromium/src/+/2668d82b0edebec82ab5e4fc76e4... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/2668d82b0edebec82ab5e4fc76e4... |
