Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2607183002: Move ev_root_ca_metadata to read-only data segment (Closed)

Created:
3 years, 11 months ago by brucedawson
Modified:
3 years, 11 months ago
Reviewers:
asanka
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ev_root_ca_metadata to read-only data segment Due to a quirk in VC++ it is easy to accidentally prevent a const global array from being placed in the read-only data segment. This change removes a should-be-harmless 'const' keyword to work around this quirk and move ~6,800 bytes to the .rdata (read-only) data segment. VC++ bug is filed here: https://connect.microsoft.com/VisualStudio/feedback/details/3117602 Other instances of this quirk are also being worked around. BUG=677351 Committed: https://crrev.com/60cd9d9826b9611587c218b5bfb59f5a75767bb2 Cr-Commit-Position: refs/heads/master@{#440977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/ev_root_ca_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
brucedawson
Simple little bug workaround to move data to the optimal data segment. PTAL.
3 years, 11 months ago (2016-12-29 18:39:26 UTC) #4
asanka
lgtm
3 years, 11 months ago (2016-12-29 19:13:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607183002/1
3 years, 11 months ago (2016-12-29 19:37:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 19:41:42 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60cd9d9826b9611587c218b5bfb59f5a75767bb2
Cr-Commit-Position: refs/heads/master@{#440977}

Powered by Google App Engine
This is Rietveld 408576698