Move ev_root_ca_metadata to read-only data segment

Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
Committed: https://crrev.com/60cd9d9826b9611587c218b5bfb59f5a75767bb2
Cr-Commit-Position: refs/heads/master@{#440977}

[brucedawson, 2016-12-29 18:38:20]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 18:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-29 18:39:26]

brucedawson@chromium.org changed reviewers:
+ asanka@chromium.org

[brucedawson, 2016-12-29 18:39:26]

Simple little bug workaround to move data to the optimal data segment. PTAL.

[asanka, 2016-12-29 19:13:41]

lgtm

[brucedawson, 2016-12-29 19:17:20]

Description was changed from

==========
Move ev_root_ca_metadata to read-only data segment

Due to a bug in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this bug
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this bug are also being worked around.

BUG=677351
==========

to

==========
Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
==========

[commit-bot: I haz the power, 2016-12-29 19:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 19:33:47]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-12-29 19:37:19]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-12-29 19:37:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 19:41:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483040239676650, "parent_rev":
"c04b4dd39f180d3e06faf097823b83cbf2a438f2", "commit_rev":
"77733adb3abef544fa4286bd0e88a7781506a369"}

[commit-bot: I haz the power, 2016-12-29 19:41:41]

Description was changed from

==========
Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351
==========

to

==========
Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Review-Url: https://codereview.chromium.org/2607183002
==========

[commit-bot: I haz the power, 2016-12-29 19:41:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:52:55]

Description was changed from

==========
Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Review-Url: https://codereview.chromium.org/2607183002
==========

to

==========
Move ev_root_ca_metadata to read-only data segment

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes a should-be-harmless 'const' keyword to work around this quirk
and move ~6,800 bytes to the .rdata (read-only) data segment.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Committed: https://crrev.com/60cd9d9826b9611587c218b5bfb59f5a75767bb2
Cr-Commit-Position: refs/heads/master@{#440977}
==========

[commit-bot: I haz the power, 2017-01-02 15:52:56]

Patchset 1 (id:??) landed as
https://crrev.com/60cd9d9826b9611587c218b5bfb59f5a75767bb2
Cr-Commit-Position: refs/heads/master@{#440977}