Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Issue 2607163002: Remove the has_pretty_patch key from layout test results JSON. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke, ojan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the has_pretty_patch key from layout test results JSON. Reason: Now, the HTML diff is always available. BUG=672651 Review-Url: https://codereview.chromium.org/2607163002 Cr-Commit-Position: refs/heads/master@{#441748} Committed: https://chromium.googlesource.com/chromium/src/+/b46e558a8922197147fd4a9094029bc753e96261

Patch Set 1 #

Patch Set 2 : Update fast/harness/results-expected.txt. #

Messages

Total messages: 17 (12 generated)
qyearsley
3 years, 11 months ago (2016-12-29 19:35:45 UTC) #2
jeffcarp
lgtm except it looks like this is breaking fast/harness/results.html
3 years, 11 months ago (2017-01-03 18:35:16 UTC) #7
qyearsley
On 2017/01/03 at 18:35:16, jeffcarp wrote: > lgtm except it looks like this is breaking ...
3 years, 11 months ago (2017-01-03 19:04:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607163002/20001
3 years, 11 months ago (2017-01-05 20:48:41 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:08:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b46e558a8922197147fd4a909402...

Powered by Google App Engine
This is Rietveld 408576698